Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] Various http2 changes #19579

Closed
wants to merge 6 commits into from
Closed

[v9.x backport] Various http2 changes #19579

wants to merge 6 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 24, 2018

Backport of the following PRs:

#18854
#13686
#18861
#18966

trivikr and others added 6 commits March 24, 2018 18:22
@trivikr @targos
test: http2 errors on req.close()
b4a99a7 
PR-URL: nodejs#18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@refack @targos
test: add more asserts to test-internal-errors
b59f421 
PR-URL: nodejs#13686
Fixes: nodejs#13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@refack @targos
test: fix common.expectsError
fd94671 
The function should strictly test for the error class and only accept
the correct one. Any other error class should fail.

PR-URL: nodejs#13686
Fixes: nodejs#13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR @targos
test: fix wrong error classes passed in as type
8e5fd45 
PR-URL: nodejs#13686
Fixes: nodejs#13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@trivikr @targos
test: http2 stream.respond() error checks
c0a9336 
PR-URL: nodejs#18861
Reviewed-By: James M Snell <[email protected]>
@addaleax @targos
http2: refer to stream errors by name
a6785dc 
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.

PR-URL: nodejs#18966
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v9.x labels Mar 24, 2018
@targos targos added the http2 Issues or PRs related to the http2 subsystem. label Mar 24, 2018
@targos
Copy link
Member Author

targos commented Mar 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13851/

@MylesBorins MylesBorins force-pushed the v9.x-staging branch 2 times, most recently from 305fe4c to 4844a26 Compare March 28, 2018 16:23
@targos
Copy link
Member Author

targos commented Mar 29, 2018

/cc @jasnell @addaleax

targos pushed a commit that referenced this pull request Mar 30, 2018
@trivikr @targos
test: http2 errors on req.close()
6bc49f0 
Backport-PR-URL: #19579
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2018
@refack @targos
test: add more asserts to test-internal-errors
cc68bc2 
Backport-PR-URL: #19579
PR-URL: #13686
Fixes: #13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2018
@refack @targos
test: fix common.expectsError
44b12c1 
The function should strictly test for the error class and only accept
the correct one. Any other error class should fail.

Backport-PR-URL: #19579
PR-URL: #13686
Fixes: #13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2018
@BridgeAR @targos
test: fix wrong error classes passed in as type
ca97be5 
Backport-PR-URL: #19579
PR-URL: #13686
Fixes: #13682
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2018
@trivikr @targos
test: http2 stream.respond() error checks
4caf536 
Backport-PR-URL: #19579
PR-URL: #18861
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2018
@addaleax @targos
http2: refer to stream errors by name
441175c 
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.

Backport-PR-URL: #19579
PR-URL: #18966
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos
Copy link
Member Author

targos commented Mar 30, 2018

Landed in 6bc49f0 cc68bc2 44b12c1 ca97be5 4caf536 and 441175c.

@targos targos closed this Mar 30, 2018
@targos targos deleted the v9.x-http2 branch March 30, 2018 13:19
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@trivikr @kjin
test: http2 stream.respond() error checks
3ba1beb 
Backport-PR-URL: nodejs#19579
PR-URL: nodejs#18861
Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@trivikr @kjin
test: http2 errors on req.close()
9d885b9 
Backport-PR-URL: nodejs#19579
PR-URL: nodejs#18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@trivikr @MylesBorins
test: http2 stream.respond() error checks
9c7bf7f 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18861
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
f5a2cd5 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 stream.respond() error checks
a77d3fa 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18861
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
42778c3 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 stream.respond() error checks
83d8ad3 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18861
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@trivikr @MylesBorins
test: http2 errors on req.close()
4dbdb8a 
Backport-PR-URL: #19579
Backport-PR-URL: #20456
PR-URL: #18854
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @jasnell @nodejs-github-bot @trivikr @refack @BridgeAR @addaleax